| From: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: regdatabase |
| Date: | 2025-05-07 14:29:43 |
| Message-ID: | CAKAnmm+-AfExyXry+vC681Y884KU_cKA1kPZ09fEP2tCjWPE6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 7, 2025 at 4:55 AM Ian Lawrence Barwick <barwick(at)gmail(dot)com>
wrote:
> Version which applies/builds against current HEAD attached. I haven't yet
> had a chance to look at the code beyond fixing it, however.
>
I too, have wanted this over the years, so +1 on the idea.
Quick review: nice patch, very thorough; applies cleanly; all tests pass;
acts as I would expect when testing manually.
Minor pgindent issue in the comment in src/backend/catalog/dependency.c
Would be nice to have test coverage of our special "single dash" case, e.g.
select regdatabase('-')::oid;
0
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-05-07 14:37:27 | Re: pg_dump does not dump domain not-null constraint's comments |
| Previous Message | Jelte Fennema-Nio | 2025-05-07 13:51:31 | Re: regdatabase |