| From: | Andrew Kim <tenistarkim(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru> |
| Subject: | Re: Proposal for enabling auto-vectorization for checksum calculations |
| Date: | 2025-11-19 01:18:36 |
| Message-ID: | CAK64mne=Q_4VSpJ8f4RQB-yAThd4+i-BRYMvfdGOhvwJQdYoKQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 17, 2025 at 8:48 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> On Tue, Nov 18, 2025 at 10:32 AM Andrew Kim <tenistarkim(at)gmail(dot)com> wrote:
>
> > I've double-checked everything after applying the v9 checksum patches
> > and updating pg_filedump accordingly.
> > Following your suggestion, I removed the checksum_impl.h include and
> > the Assert redefinition, keeping only the port/checksum.h include.
> > build compiles cleanly with the new architecture, and pg_filedump
> > functions correctly with the AVX2 optimizations.
> > If you agree with this approach, I'd like to prepare a patch for
> > upstream submission.
>
> Thanks, but there is no action required now. I mentioned some
> observations, and I'm going to experiment a bit further.
>
> Also, it's way too early to be suggesting changes to other projects,
> since we haven't committed anything yet. Even things committed can
> occasionally be reverted before beta 1 anyway.
It makes sense, I fully understand. I will standby and wait for your
next update.
-Andrew Kim
> --
> John Naylor
> Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-11-19 01:30:49 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Chao Li | 2025-11-19 01:17:07 | Re: Post-release followup: pg_add_size_overflow() |