| From: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | mb_regress.sh gripes |
| Date: | 2011-08-18 22:19:25 |
| Message-ID: | CAK3UJRGVdG=qWS0UcHHA7+C8nRSF=93MA1Kn7awx7K73UUA5=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
A few gripes about mb_regress.sh:
1. No exit code is specified, so even if there are differences
between results/ and expected/ the script will still return 0.
2. The 'dropdb' command is used to wipe out the "utf8" database
before the run. This generates an error message like:
dropdb: database removal failed: ERROR: database "utf8" does not exist
the first time you run the script. IMO it would be less startling to
just print a NOTICE here.
3. No error checking for whether createdb succeeds.
The attached patch fixes these problems.
Josh
| Attachment | Content-Type | Size |
|---|---|---|
| mb_regress_gripes.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-08-18 22:56:35 | "make -j4 world" falls over |
| Previous Message | Robert Haas | 2011-08-18 20:04:23 | Re: the big picture for index-only scans |