| From: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>, David Steele <david(at)pgmasters(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Joel Jacobson <joel(at)compiler(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Date: | 2021-03-15 15:29:20 |
| Message-ID: | CAJvoCuuDNi_m7dc0oiqxNtO32X5QKRj9cJ=a6GhoM6BuOQ3cVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hey Justin,
I think the expected results are actually wrong, with the linux CI failing
> but
> actually returning the right results.
Yes, this was an oversight on my part. Fixed gin regression test expected
output.
I have a fix which passes (modified) tests, although I doubt it's
> complete. I think this patch will need additional review - more than I can
> give.
Actually, your fix led me in the right way, the issue was how windows
handle pointers.
This time around I have copied CFbot's CI config and cloned it to my repo
and started testing instead of spamming the mailing list with trial and
error patches. v9 now passes all tests on my CI, I guess we'll wait and see
what CFbot has to say.
Changelog:
- v9 (compatible with current master 2021-03-15,
commit eeb60e45d82d5840b713a8741ae552238d57e8b9)
* refractor "ginarrayproc.c" (fix pointer logic and refactor
ginconsistency + gintriconsistency)
* clean elementfk regression test
* fix gin regression test expected
/Mark
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-anyarray_anyelement_operators.patch | text/x-patch | 29.8 KB |
| v9-0002-fk_arrays_elems.patch | text/x-patch | 117.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gilles Darold | 2021-03-15 15:41:04 | Re: MultiXact\SLRU buffers configuration |
| Previous Message | Rafal Pietrak | 2021-03-15 15:28:42 | Fwd: row level security (RLS) |