| From: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Joel Jacobson <joel(at)compiler(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, David Steele <david(at)pgmasters(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Date: | 2021-01-28 21:41:32 |
| Message-ID: | CAJvoCusQzaWE-WwsagWtHFuX7H5sScgXO2bNXY1UYOx9F13zLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Zhihong,
Thank you for your review, please continue giving feedback, your help is
appreciated!
I think the ARR_HASNULL(arr) condition is not reflected in the error
> message.
>
Added to v16
I don't see CASCADE in the if condition that follows the above comment.
>
Added to v16
The code would be FKCONSTR_REF_EACH_ELEMENT and FKCONSTR_REF_PLAIN. I think
> you can mention them in the comment.
>
Added to v16
Changelog (Main Patch):
- v16 (compatible with current master 2021-01-28
commit 6f5c8a8ec23f8ab00da4d2b77bfc8af2a578c4d3)
* added customised message for ARR_HASNULL(arr)
* removed DELETE CASCADE comment
* added FKCONSTR_REF_EACH_ELEMENT and FKCONSTR_REF_PLAIN comment
* added is array check on FK creation
* total rewrite of "generate_operator_clause" edit (shift to <@ instead
of @> for less code)
Changelog (ContainsElem):
- v2 (comaptible with v16):
* made compatible with Main Patch v16
>
The next step is performance benchmarking, will report the results soon.
/Mark
| Attachment | Content-Type | Size |
|---|---|---|
| Array-containselem-gin-v2.patch | text/x-patch | 24.4 KB |
| Array-ELEMENT-foreign-key-v16.patch | text/x-patch | 110.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Rofail | 2021-01-28 21:41:43 | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Previous Message | Tom Lane | 2021-01-28 20:22:51 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |