Re: macaddr 64 bit (EUI-64) datatype support

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Shay Rojansky <roji(at)roji(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: macaddr 64 bit (EUI-64) datatype support
Date: 2017-01-27 15:52:34
Message-ID: CAJrrPGfzQgLQneaEeXUGMzifA3SUgUCcs1NfdZahRc6+t881=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Jan 27, 2017 at 6:10 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
wrote:

> On Wed, Jan 25, 2017 at 6:00 PM, Haribabu Kommi
> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>
> > Corrected as suggested.
> >
> > Updated patch attached. There is no change in the contrib patch.
> Got whitspace error warning while applying contrib_macaddr8_1.patch:184.
>

Corrected.

> diff --git a/contrib/btree_gist/btree_gist.control
> b/contrib/btree_gist/btree_gist.control
> index ddbf83d..fdf0e6a 100644
> --- a/contrib/btree_gist/btree_gist.control
> +++ b/contrib/btree_gist/btree_gist.control
> @@ -1,5 +1,5 @@
> # btree_gist extension
> comment = 'support for indexing common datatypes in GiST'
> -default_version = '1.3'
> +default_version = '1.4'
> btree_gin.control should be updated as well. Otherwise, make
> check-world is throwing error.
>
> After making the above changes, I'm able to run regression test
> successfully without any error/warning.

Corrected the change in btree_gin.control file also.
Thanks for the review.

Updated patches are attached.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
mac_eui64_support_9.patch application/octet-stream 46.9 KB
contrib_macaddr8_2.patch application/octet-stream 20.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-01-27 16:03:05 Re: One-shot expanded output in psql using \G
Previous Message Haribabu Kommi 2017-01-27 15:50:01 Re: macaddr 64 bit (EUI-64) datatype support