| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Shay Rojansky <roji(at)roji(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: macaddr 64 bit (EUI-64) datatype support |
| Date: | 2017-01-27 15:50:01 |
| Message-ID: | CAJrrPGfiSivBJS8gWqxrorT7ddC2pBsWZ1CzmnuH1Xj2_uATrg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 26, 2017 at 9:42 PM, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
wrote:
> On 1/25/17, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> > On Wed, Jan 25, 2017 at 6:43 PM, Vitaly Burovoy <
> vitaly(dot)burovoy(at)gmail(dot)com>
> > wrote:
> >
> I'm going to do (I hope) a final review tonight.
> Please, remove initialization of the variables "d" and "e" since there
> is really no reason to keep them be zero for a short time.
Thanks for the review. Corrected in the latest patch.
Regards,
Hari Babu
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2017-01-27 15:52:34 | Re: macaddr 64 bit (EUI-64) datatype support |
| Previous Message | David G. Johnston | 2017-01-27 15:46:56 | Re: One-shot expanded output in psql using \G |