From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
---|---|
To: | "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Transaction commits VS Transaction commits (with parallel) VS query mean time |
Date: | 2019-03-19 07:51:15 |
Message-ID: | CAJrrPGf7h+p81ZgCOGB=6Ukj9pWE8WY5wok4zYjtEpFsuca_MQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 19, 2019 at 6:47 PM Jamison, Kirk <k(dot)jamison(at)jp(dot)fujitsu(dot)com>
wrote:
> Hi Hari-san,
>
>
>
> On Sunday, February 10, 2019 2:25 PM (GMT+9), Haribabu Kommi wrote:
>
> > I try to fix it by adding a check for parallel worker or not and based
> on it
>
> > count them into stats. Patch attached.
>
> >
>
> > With this patch, currently it doesn't count parallel worker
> transactions, and
>
> > rest of the stats like seqscan and etc are still get counted. IMO they
> still
>
> > may need to be counted as those stats represent the number of tuples
>
> > returned and etc.
>
> >
>
> > Comments?
>
>
>
> I took a look at your patch, and it’s pretty straightforward.
>
> However, currently the patch does not apply, so I reattached an updated one
>
> to keep the CFbot happy.
>
>
>
> The previous patch also had a missing header to detect parallel workers
>
> so I added that. --> #include "access/parallel.h"
>
Thanks for update and review krik.
Regards,
Haribabu Kommi
Fujitsu Australia
From | Date | Subject | |
---|---|---|---|
Next Message | Tsunakawa, Takayuki | 2019-03-19 07:53:27 | RE: Speed up transaction completion faster after many relations are accessed in a transaction |
Previous Message | Haribabu Kommi | 2019-03-19 07:50:09 | Re: Transaction commits VS Transaction commits (with parallel) VS query mean time |