| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Dave Page <dpage(at)pgadmin(dot)org> |
| Subject: | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Date: | 2019-01-10 06:40:54 |
| Message-ID: | CAJrrPGf-ceZQyTYP5FT_yLttQBG2_1hxsRwjdmXtqsfNcHEvOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 10, 2019 at 2:32 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Jan 9, 2019 at 10:26 AM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
> >
> >
> > On Wed, Jan 9, 2019 at 2:25 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> >>
> >> Another minor point is that in the second statement
> >> (pg_stat_statements_reset), you seem to have made it a two-line
> >> statement whereas first one looks to be a single-line statement, it
> >> would be good from the readability point of view if both looks same.
> >> I would prefer the second to look similar to the first one.
> >
> >
> > OK. Corrected.
> >
> > Updated patch attached.
> >
>
> I am happy with this patch now, attached is the new version of the
> patch where I have slightly modified the commit message, see if that
> looks fine to you. I will push this patch tomorrow morning (after
> again going through it) unless someone has any objections or see any
> other issues.
>
Thanks for changes. LGTM.
Regards,
Haribabu Kommi
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-01-10 07:44:35 | Re: insensitive collations |
| Previous Message | Imai, Yoshikazu | 2019-01-10 06:37:27 | RE: speeding up planning with partitions |