Re: Stopping logical replication protocol

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Vladimir Gordiychuk <folyga(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Álvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: Stopping logical replication protocol
Date: 2016-12-02 02:25:29
Message-ID: CAJrrPGek2QcYiuwQRoHV_94xxzn795RY+i8mqUXRbKAT=6vXtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Nov 4, 2016 at 12:44 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:

> On 21 October 2016 at 19:38, Vladimir Gordiychuk <folyga(at)gmail(dot)com> wrote:
> > Craig, Andres what do you thinks about previous message?
>
> I haven't had a chance to look further to be honest.
>
> Since a downstream disconnect works, though it's ugly, it's not
> something I can justify spending a lot of time on, and I already did
> spend a lot on it in patch review/updating/testing etc.
>
> I don't know what Andres wants, but I think CopyFail with
> ERRCODE_QUERY_CANCELED is fine.
>
> As for plugins that collect changes in memory and only send them on
> commit, I'd call them "broken". Not an interesting case IMO. Don't do
> that.
>

Currently the patch is marked as "returned with feedback" as there are some
comments from reviewer.

Please free to submit an update patch to the next commitfest.

Regards,
Hari Babu
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2016-12-02 02:26:55 Re: [PATCH] Reload SSL certificates on SIGHUP
Previous Message Haribabu Kommi 2016-12-02 02:18:24 Re: btree_gin and btree_gist for enums