Re: Removal of duplicate variable declarations in fe-connect.c

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Removal of duplicate variable declarations in fe-connect.c
Date: 2019-02-22 07:50:18
Message-ID: CAJrrPGeQdr-YfLdeGxMFb4erqNWU77E49mD2HoHPntHTBY26Ag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 22, 2019 at 3:22 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> > During the development of another feature, I found that same local
> > variables are declared twice.
> > IMO, there is no need of again declaring the local variables. Patch
> > attached.
>
> Indeed, fixed. That's not a good practice, and each variable is
> assigned in its own block before getting used, so there is no
> overlap.
>

Thanks.

Regards,
Haribabu Kommi
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2019-02-22 08:10:49 Re: pg_basebackup ignores the existing data directory permissions
Previous Message Haribabu Kommi 2019-02-22 07:49:55 Re: Libpq support to connect to standby server as priority