Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, sk(at)zsrv(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query
Date: 2018-07-09 05:39:34
Message-ID: CAJrrPGeOf2k17rnMikv56m-exR9tOnjBvsZzuLeQgknnPjey_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 9, 2018 at 12:24 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Fri, Jul 06, 2018 at 05:10:18PM -0400, Alvaro Herrera wrote:
> > Ugh, it's true :-(
> >
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=25fff40798fc4ac11a241bfd9ab0c45c085e2212#patch8
> >
> > Dave, Simon, any comments?
>
> The offending line:
> contrib/pg_stat_statements/pg_stat_statements--1.4--1.5.sql:
> GRANT EXECUTE ON FUNCTION pg_stat_statements_reset() TO pg_read_all_stats;
>
> This will need a new version bump down to REL_10_STABLE...
>

Hearing no objections, attached patch removes all permissions from PUBLIC
as before this change went in. Or do we need to add command for revoke only
from pg_read_all_stats?

Regards,
Haribabu Kommi
Fujitsu Australia

Attachment Content-Type Size
0001-Revoke-pg_stat_statements_reset-permissions.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-07-09 05:47:06 Re: [HACKERS] Restricting maximum keep segments by repslots
Previous Message Andres Freund 2018-07-09 05:28:15 Re: Postgres 11 release notes