Re: [HACKERS] Pluggable storage

On Sat, Jan 6, 2018 at 6:31 AM, Alexander Korotkov <
a(dot)korotkov(at)postgrespro(dot)ru> wrote:

> On Fri, Jan 5, 2018 at 7:20 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> I do not like the way that this patch set uses the word "storage". In
>> current usage, storage is a thing that certain kinds of relations
>> have. Plain relations (a.k.a. heap tables) have storage, indexes have
>> storage, materialized views have storage, TOAST tables have storage,
>> and sequences have storage. This patch set wants to use "storage AM"
>> to mean a replacement for a plain heap table, but I think that's going
>> to create a lot of confusion, because it overlaps heavily with the
>> existing meaning yet is different.
>
>
> Good point, thank you for noticing that. Name "storage" is really
> confusing
> for this purpose.
>

Thanks for the review and suggestion.

> My suggestion is to call these
>> "table access methods" rather than "storage access methods". Then,
>> the default table AM can be heap. This has the nice property that you
>> create an index using CREATE INDEX and the support functions arrive
>> via an IndexAmRoutine, so correspondingly you would create a table
>> using CREATE TABLE and the support functions would arrive via a
>> TableAmRoutine -- so all the names match.
>>
>
I changed the patches to use Table instead of storage. Changed all the
structures and exposed functions also for better readability

Updated patches are attached.

Regards,
Hari Babu
Fujitsu Australia