Re: macaddr 64 bit (EUI-64) datatype support

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Shay Rojansky <roji(at)roji(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: macaddr 64 bit (EUI-64) datatype support
Date: 2016-11-07 02:40:34
Message-ID: CAJrrPGdDWw0OXFGh_E_1Vxxn1g8AgVKk-aLmnfOyTpxoXnqvrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 7, 2016 at 8:40 AM, Shay Rojansky <roji(at)roji(dot)org> wrote:

> > 1. Does everyone agrees that renaming the existing datatype without
>> > changing the OID?
>> >
>> >
>> > As I said before, Npgsql for one loads data types by name, not by OID.
>> > So this would definitely cause breakage.
>>
>> Why would that cause breakage?
>
>
> Well, the first thing Npgsql does when it connects to a new database, is
> to query pg_type. The type names are used to associate entries with type
> handlers, avoiding the hard-coding of OIDs in code. So if the type name
> "macaddr" suddenly has a new meaning and its wire representation is
> different breakage will occur. It is possible to release new versions of
> Npgsql which will look at the PostgreSQL version and say "we know that in
> PostgreSQL < 10 macaddr means this, but in >= 10 it means that". But that
> doesn't seem like a good solution, plus old versions of Npgsql from before
> this change won't work.
>

The new datatype that is going to replace the existing one works with both
6 and 8 byte
MAC address and stores it a variable length format. This doesn't change the
wire format.
I don't see any problem with the existing applications. The new datatype
can recv and send
8 byte MAC address also.

Regards,
Hari Babu
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2016-11-07 03:36:18 Re: pg_hba_file_settings view patch
Previous Message Etsuro Fujita 2016-11-07 02:28:28 Re: Typo in comment in contrib/postgres_fdw/deparse.c