Re: BUG #13741: vacuumdb does not accept valid password

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, brown(at)fastmail(dot)com, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13741: vacuumdb does not accept valid password
Date: 2015-11-12 06:03:17
Message-ID: CAJrrPGd3hCrOQ2cNWteMvgxczg9p2m=hWUeRpLzNCWJPauLrkw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Nov 6, 2015 at 5:53 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Nov 4, 2015 at 4:30 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Wed, Nov 4, 2015 at 11:16 AM, Alvaro Herrera
>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>> Haribabu Kommi wrote:
>>>> On Wed, Nov 4, 2015 at 11:24 AM, Haribabu Kommi
>>>> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>>>
>>>> And one more thing, the vacuumdb password behavior is present in back branches
>>>> also, is it worth back patching the vacuumdb fix to all supported
>>>> branches and apply
>>>> the jobs connection fix only to master and 9.5?
>>>
>>> Given the lack of complaints, I doubt it's worth the destabilization
>>> risk. Let's just patch 9.5 and be done with it.
>>
>> Fine for me. --all is supported for ages.
>
> OK, so attached is a patch aimed at master and 9.5. I reused the
> suggestion of Haribabu to not rely completely on the maintenance
> database after testing with a couple of database, some of them using
> md5 and others trust. That's just more portable this way, and user
> just needs to specify the password once to be done even with vacuumdb
> --all.
> Thoughts?

Thanks for the patch. Yes, reusing the password helps for --analyze-in-stages
for single database case also along with -all.

Regards,
Hari Babu
Fujitsu Australia

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message 許耀彰 2015-11-12 12:11:03 postgresql downgrade issue
Previous Message nararya.anugraha 2015-11-12 05:49:31 BUG #13772: Mistranslation in Indonesian

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2015-11-12 06:30:07 Re: Foreign join pushdown vs EvalPlanQual
Previous Message Michael Paquier 2015-11-12 05:54:39 Re: Per-table log_autovacuum_min_duration is actually documented