Re: Enhance pg_stat_wal_receiver view to display connected host

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enhance pg_stat_wal_receiver view to display connected host
Date: 2017-12-22 04:11:07
Message-ID: CAJrrPGd2NEV=Mjo9CAJj2hgP+uOY76vM9HBofb278J59RMioMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 21, 2017 at 11:12 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com
> wrote:

> On Thu, Dec 21, 2017 at 8:16 PM, Haribabu Kommi
> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> > The current connected host details are already available in the PGconn
> > structure,
> > Exposing those details in the view will suffice this requirement.
> Currently
> > these
> > members are characters pointers, I used them as it is and displayed them
> in
> > the
> > view as character arrays except the port number.
> >
> > Attached the draft patch. Any comments?
>
> I agree that it would be nice to have an equivalent to
> pg_stat_replication's client_addr, client_hostname, client_port on the
> receiver side, particularly because it is possible to list multiple
> hosts and ports. Could you add that to the next commit fest?
>

Added.

> Please note that you need to update rules.out and the documentation
> because of the new fields.
>

Updated patch attached with tests and doc changes.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
pg_stat_wal_receiver-to-display-connected-host_v1.patch application/octet-stream 13.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2017-12-22 04:16:02 Re: WIP: a way forward on bootstrap data
Previous Message Chapman Flack 2017-12-22 03:48:49 reassure me that it's good to copy pg_control last in a base backup