Re: pg_stat_wal_write statistics view

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_wal_write statistics view
Date: 2017-03-16 01:34:11
Message-ID: CAJrrPGc_Y4V_Aaj=smO3Sui+6PS9d3KtE0_mwVH+m9p7Dkgreg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Mar 16, 2017 at 9:55 AM, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>
wrote:

> On Wed, Feb 15, 2017 at 02:53:44PM +1100, Haribabu Kommi wrote:
> > Here I attached patch that implements the view.
> > I will add this patch to next commitfest.
>
> Hello,
>
> I just reviewed the patch.
>

Thanks for the review.

First, there are some whitespace issues that make git-apply complaining (at
> least lines 218 and 396).
>

Removed.

Patch is rather straightforward and works as expected, doc compiles without
> issue.
>
> I only found some minor issues:
>
> + <entry>One row only, showing statistics about the
> + wal writing activity. See
>
> + <entry>Number of wal writes that are carried out by the backend
> process</entry>
>
>
> WAL should be uppercase (and for some more occurences).
>

Fixed.

> + <entry>
> + Number of wal writes that are carried out by background workers
> such as checkpointer,
> + writer and walwriter.
>
> I guess you meant backgroung processes?
>

Yes, it is background processes. Updated.

> >+ This field data will be populated only when the track_io_timing
> GUC is enabled
> (and similar occurences)
>
> track_io_timing should link to <xref linkend="guc-track-io-timing">
> instead of
> mentionning GUC.
>

Updated accordingly.

I think you also need to update the track_io_timing description in
> sgml/config.sgml to mention this new view.
>

Added the reference of pg_stat_walwrites in the GUC description.

>
> + else
> + {
> + LocalWalWritesStats.m_wal_total_write_time = 0;
> + }
> (and similar ones)
>
> The brackets seem unnecessary.
>

Corrected.

Updated patch attached.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
pg_stat_walwrites_view_2.patch application/octet-stream 26.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-03-16 01:40:07 Re: Partition-wise join for join between (declaratively) partitioned tables
Previous Message Michael Paquier 2017-03-16 01:22:15 Re: Speedup twophase transactions