Re: Refactor handling of database attributes between pg_dump and pg_dumpall

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactor handling of database attributes between pg_dump and pg_dumpall
Date: 2017-11-07 23:50:57
Message-ID: CAJrrPGcMJj-+ktvKWqt8Q-=_SXxbo_Xu+RpzPRfWrGnekwQ3eA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, Nov 8, 2017 at 8:48 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Tue, Nov 7, 2017 at 4:35 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
> > The newly added option is not recommended to be used in normal cases and
> > it is used only for upgrade utilities.
>
> I don't know why it couldn't be used in normal cases. That seems like
> a totally legitimate thing for somebody to want. Maybe nobody does,
> but I see no reason to worry if they do.

Ok. Removed the documentation changes that it cannot be used for normal
scenarios, and also added a Note section explaining the problem of using
the dump with pg_restore command with --clean and --create options.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
pg_dump-and-pg_dumpall-database-handling-refactoring_v10.patch application/octet-stream 49.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-11-07 23:57:50 Re: Parallel Hash take II
Previous Message Peter Geoghegan 2017-11-07 23:31:22 Re: MERGE SQL Statement for PG11