| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: How can end users know the cause of LR slot sync delays? |
| Date: | 2025-11-27 05:12:05 |
| Message-ID: | CAJpy0uDr4wagHLyLmhq1w7HWzAdi5f7MkoHLK3b9Bem_697wJg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 27, 2025 at 9:25 AM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> I have made some minor changes in documentation and comments. Attached
> the updated patch.
>
1)
<literal>NULL</literal> if
slot synchronization is successful.
We shall add 'It is' to maintain continuity as the previous sentence has it.
2)
Related to previous patch: pgstat_report_replslotsync() currently has
sanity check Assert(SlotIsLogical(slot));
Instead, shall we have Assert(slot->synced)? It will implicitly ensure
that the slot is logical, plus it is important to check that we are
updating stats of synced slot only.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-11-27 05:17:15 | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Previous Message | Michael Paquier | 2025-11-27 04:29:56 | Move WAL/RMGR sequence code into its own file and header |