Re: Conflict detection for update_deleted in logical replication

On Fri, Jun 27, 2025 at 7:58 AM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Thu, Jun 26, 2025 at 4:28 PM shveta malik wrote:
> >
> > On Thu, Jun 26, 2025 at 8:31 AM Zhijie Hou (Fujitsu)
> > <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > >
> > > Thanks for the comments. All of them look good to me and
> > > have been addressed in V42.
> > >
> >
> > Thank You for the patches. Few comments.
> >
> > t/035_conflicts.pl:
> >
> > 1)
> > Both the subscriptions subname_BA and subname_AB have rci enabled
> > during CREATE sub itself. And later in the second test, we are trying
> > to enable rci of subname_AB to test WARNING and NOTICE, but rci is
> > already enabled. Shall we have one CREATE sub with rci enabled while
> > another CREATE sub with default rci. And then we try to enable rci of
> > the second sub later and check pg_conflict_detection slot has been
> > created once we enabled rci. This way, it will cover more scenarios.
>
> Agreed and changed as suggested. I removed the test for WARNING since the
> message is the same as the NOITCE and it seems not worthwhile to disable
> the subscription again to verify one message.
>

Okay. Agreed.

patch001 looks good to me now.

thanks
Shveta