Re: Logical Replication of sequences

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Logical Replication of sequences
Date: 2025-07-21 06:47:13
Message-ID: CAJpy0uDQE4E0_F3JUXrOf2grd79E7nxvwPNZ_3wnKCATmOKQTg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 21, 2025 at 11:15 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> 3. Some of the syntaxes works for sequence which doesn't make sense to
> me, as listed below, I think there are more
>
> postgres[154731]=# CREATE PUBLICATION insert_only FOR ALL SEQUENCES
> WITH (publish = 'insert');
> CREATE PUBLICATION
>
> postgres[154731]=# CREATE PUBLICATION pub FOR ALL SEQUENCES WITH (
> PUBLISH_VIA_PARTITION_ROOT );
> CREATE PUBLICATION

+1. I had the same concerns at [1]. It might be feasible to restrict
this if we have CREATE SUB for ALL SEQ alone. But if we have ALL
SEQUENCES and ALL TABLES together, then 'WITH' makes sense for tables
but not for sequences. My suggestion earlier was to display a NOTICE
at-least to say that WITH is not applicable to SEQUENCES (in case we
can not restrict it).

[1]: https://www.postgresql.org/message-id/CAJpy0uBFXJLOiFOL8QgSeS93Bf%3DZQd86BXZa%3DMeijHQo-%3Da2cA%40mail.gmail.com

thanks
Shveta

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-07-21 06:52:49 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Previous Message Peter Smith 2025-07-21 06:46:48 Re: Skipping schema changes in publication