Re: pgsql: Track last_inactive_time in pg_replication_slots.

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: pgsql: Track last_inactive_time in pg_replication_slots.
Date: 2024-03-26 04:25:19
Message-ID: CAJpy0uCofjiCZgqf_mNohh62+p-Mi+Y0dpQ8WFZsD_f3EfY7NQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Mar 26, 2024 at 1:50 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Tue, Mar 26, 2024 at 1:30 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> >
> > On Mon, Mar 25, 2024 at 04:49:12PM +0000, Bertrand Drouvot wrote:
> > > On Mon, Mar 25, 2024 at 12:25:37PM -0400, Robert Haas wrote:
> > >> In the same vein, I think deactivated_at or inactive_since might be
> > >> good names to consider. I think they get at the same thing as
> > >> released_time, but they avoid introducing a completely new word
> > >> (release, as opposed to active/inactive).
> > >
> > > Yeah, I'd vote for inactive_since then.
> >
> > Having only skimmed some of the related discussions, I'm inclined to agree
> > that inactive_since provides the clearest description for the column.
>
> I think we all have some agreement on inactive_since. So, I'm
> attaching the patch for that change.

pg_proc.dat needs to be changed to refer to 'inactive_since' instead
of 'last_inactive_time' in the attached patch.

thanks
Shveta

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2024-03-26 05:01:16 Re: pgsql: pg_createsubscriber: creates a new logical replica from a standb
Previous Message Masahiko Sawada 2024-03-26 04:14:14 pgsql: Fix inconsistent function prototypes with function definitions.

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-03-26 04:25:31 Re: Add new error_action COPY ON_ERROR "log"
Previous Message shveta malik 2024-03-26 04:07:48 Re: pgsql: Track last_inactive_time in pg_replication_slots.