| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Manu <manuelreyesbravo(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: [PG19] Promotion hangs behind a backend blocked on a stuck client |
| Date: | 2026-10-22 04:53:23 |
| Message-ID: | CAJpy0uCYqeFQrqkxO74TbqSTwGPhzAtsrV+TfJjoigN=Mja08g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 21, 2026 at 10:47 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Oct 21, 2026 at 6:09 AM shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> >
> > I agree. 19 gets a note in the docs, and v6 goes to master first.
> >
> > The docs patch for 19 is attached. It says what blocks, how to see the
> > PID, and how to get out. I am happy to change the wording.
> >
>
> <para>
> + To avoid the wait, set <varname>wal_level</varname> to
> + <literal>logical</literal> on the standby.
>
> Will this help when the promotion is stuck? I feel this defeats the
> purpose of the feature introduced in commit 67c20979ce7.
+1.
I like the doc idea on PG19 and the patch 'fix_doc.1'. A few comments:
1)
+ <literal>replica</literal> that has a logical replication slot at the end
+1 on what Kuroda-san pointed. I think we should mention 'valid' slots
2)
It would be better to link tcp_user_timeout (and wal_level) rather
than only naming it, so readers can find the platform and Unix-socket
restrictions.
3)
+ To bound such waits in advance, set
+ <varname>tcp_user_timeout</varname> on the standby, where supported by
+ the operating system. The setting takes effect only for connections
+ established after it is configured, and does not affect a connection
+ whose backend is already blocked.
Shall we change to:
To bound such waits in advance, set tcp_user_timeout on the standby;
it applies only to TCP connections, on platforms that support it.
After a configuration reload, an existing session picks up the new
value when its client sends the next query. Consequently, the setting
does not affect a backend that is already blocked.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-10-22 05:12:09 | RE: [PG19] Promotion hangs behind a backend blocked on a stuck client |
| Previous Message | Suraj Kharage | 2026-10-22 04:39:26 | Re: [PATCH] Add support for INSERT ... SET syntax |