| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Date: | 2025-12-19 03:53:16 |
| Message-ID: | CAJpy0uCXKPz=kbyBPqnKOqvZm8QAELQDy=LX0RCXt3GnCAa2rA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 19, 2025 at 6:13 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> >
>
> I've rebased the patch and addressed the review comments.
>
> Regards,
>
Thanks for the patch.
1)
+ * There could be some transactions that might have started with the old
+ * status, but we don't need to wait for these transactions to complete as
+ * long as they valid XIDs. These transactions will appear in the
they valid --> they have valid
2)
+ * One might think we need to wait for all running transactions, including
+ * read-only transactions, to finish before enabling logical decoding.
Suggestion to change it slightly to make it more clear:
One might think we need to wait for all running transactions,
including those without XIDs and read-only ones, to finish before
enabling logical decoding.
~~
Apart from the above trivial corrections, I have no more comments.
I’ll conclude my review here; the patch LGTM.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-12-19 04:01:36 | Re: DOCS - Clarify the publication 'publish_via_partition_root' default value. |
| Previous Message | Xuneng Zhou | 2025-12-19 03:38:24 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |