| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-01-28 12:06:56 |
| Message-ID: | CAJpy0uC4a2SpBBO7cgiKdaEzYu9t7oQMsm9oVHtGaDOEkjta1g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 28, 2026 at 5:33 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
>
> 4)
> +# Verify that '2' is present inside the JSON structure using a regex
> +# This matches the key/value pattern for "a": 2
> +like($raw_json, qr/\\"a\\":2/, 'Verified that key 2 exists in the
> local_conflicts');
> +
Oops, I missed adding my feedback for pt4 earlier, here it is:
To properly validate correctness, given that local_conflicts is an
array of multiple local tuple details here, we should also check that
it contains the keys b:3 and c:4.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-01-28 12:20:56 | trivial designated initializers |
| Previous Message | shveta malik | 2026-01-28 12:03:48 | Re: Proposal: Conflict log history table for Logical Replication |