| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-05-21 10:39:23 |
| Message-ID: | CAJpy0uC43NTKheuLo+MsHG7Sfh-QWQM9QP-EVPL5LChiPfisJw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Few comments on doc patches v36-008 and 009 combined:
1)
+ An array of JSON objects representing the local state for each
conflict attempt.
'each conflict attempt' looks misleading. We do not attempt to cause
conflicts; we attempt to apply, but it may result in conflicts.
Shall we rephrase to:
'An array of JSON objects representing the state of existing local
row(s) that caused the conflict.'
There could be multiple rows as well for multiple_unique_conflicts,
thus the 'row(s)'
2)
+ The <link linkend="sql-createsubscription-params-with-conflict-log-destination"><literal>conflict_log_destination</literal></link>
+ parameter automatically creates a dedicated conflict log table.
'conflict_log_destination' parameter does not create the table
automatically unless it is set to table. We shall clarify it.
The conflict_log_destination when set to table or all automatically
creates a dedicated conflict log table.
3)
+ Conflicts that occur during replication are, by default, logged as
plain text
When we say 'Conflicts' here, we shall make it a link to '29.8.
Conflicts' chapter. That way it will be more clear.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Nitin Motiani | 2026-05-21 09:56:43 | Re: Adding pg_dump flag for parallel export to pipes |