Add comment to specify timeout unit in ConditionVariableTimedSleep()

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Add comment to specify timeout unit in ConditionVariableTimedSleep()
Date: 2024-03-05 04:09:11
Message-ID: CAJpy0uC=xiBQD1WapgYYvOiytap6ULJaakLd867zZXqu9tYc8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

ConditionVariableTimedSleep() accepts a timeout parameter, but it
doesn't explicitly state the unit for the timeout anywhere. To
determine this, one needs to look into the details of the function to
find it out from the comments of the internally called function
WaitLatch(). It would be beneficial to include a comment in the header
of ConditionVariableTimedSleep() specifying that the timeout is in
milliseconds, similar to what we have for other non-static functions
like WaitLatch and WaitEventSetWait. Attached the patch for the same.

thanks
Shveta

Attachment Content-Type Size
v1-0001-Specify-timeout-unit-in-ConditionVariableTimedSle.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2024-03-05 04:28:32 Re: remaining sql/json patches
Previous Message Kyotaro Horiguchi 2024-03-05 04:04:55 Re: initdb's -c option behaves wrong way?