| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-08-13 05:40:37 |
| Message-ID: | CAJpy0uBgduKoj02TeCG8TiqDiC-f+aj-CB0NW4vApV_JKur_Uw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 12, 2026 at 9:13 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
>
> Changed.
>
Thanks Dilip. A few trivial comments on v69:
1)
+insert_conflict_log_tuple(Relation conflictlogrel, HeapTuple tuple)
+{
+ Assert(tuple != NULL);
+
+ heap_insert(conflictlogrel, tuple,
+ GetCurrentCommandId(true), 0, NULL);
+}
Should we get rid of this function now?
a) It does not do anything extra other than heap_insert()
b) There is only one caller.
2)
LOG: conflict detected on relation "public.tab1": conflict=delete_missing
DETAIL: Conflict details are logged to the conflict log table:
pg_conflict_log_16390
It will be good to specify schema qualified name here:
pg_conflict.pg_conflict_log_16390, as we do at other places.
3)
The doc page shows:
29.8.1. Conflict logging
29.8.2. Table-based logging
29.8.3. File-based logging
29.8.4. Notes
Should it be:
29.8.1. Conflict logging
29.8.1.1. Table-based logging
29.8.1.2. File-based logging
29.8.2. Notes
What do you say?
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-08-13 05:42:42 | RE: Logical replication row filter loses unchanged toasted columns |
| Previous Message | Fujii Masao | 2026-08-13 05:31:53 | Re: analyze-in-stages post upgrade questions |