| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: How can end users know the cause of LR slot sync delays? |
| Date: | 2025-11-24 05:53:56 |
| Message-ID: | CAJpy0uBZSqxhhL43CVTSNzbqxsgtFuej-fOOMx=3sPZLEAL3LA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 21, 2025 at 6:21 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> The Cbot complained that it was not able to build the docs. I have
> fixed it and attached the latest patch.
>
Few comments on 001:
1)
In pgstat_report_replslotsync_skip(), shall we have a sanity check to
ensure that slot is logical and function is called on a
standby(RecoveryInProgress)?
2)
In update_and_persist_local_synced_slot(), we have comments at 3
places to indicate that stats are updated in some other
function.Instead, shall we have a generic comment in the header of
this function?
3)
Shall we have the test moved to the existing file
040_standby_failover_slots_sync?
4)
We should be able to make test work without injection point, please
try for that. Also it should be enough to test stats for one flow
instead of multiple flows.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2025-11-24 05:54:54 | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Previous Message | Amit Kapila | 2025-11-24 05:49:23 | Re: How can end users know the cause of LR slot sync delays? |