Re: [PATCH] Preserve replication origin OIDs in pg_upgrade

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, Rui Zhao <zhaorui126(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: [PATCH] Preserve replication origin OIDs in pg_upgrade
Date: 2026-08-27 06:31:08
Message-ID: CAJpy0uBQcm046ZQDa5chikOseBfE5CZ+sieT5Dqp=8FGA-apZw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 27, 2026 at 11:44 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Shveta,
>
> > a) Check for pre-existing origins on the new cluster regardless of the
> > old cluster's origin count?
> > b) Or update the doc to make it consistent with code, at-least for our
> > origin case?
> > c) Leave things as they are?
>
> Personally I prefer c), no need to update documents and codes, because it's the
> same behavior for replication slots.
>

Okay, works for me.

thanks
Shveta

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-08-27 07:06:08 Re: pg_upgrade silently truncates nextMultiOffset to 32 bits
Previous Message shveta malik 2026-08-27 06:27:57 Re: [PATCH] Release replication slot on error in SQL-callable slot functions