Re: sequencesync worker race with REFRESH SEQUENCES

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: sequencesync worker race with REFRESH SEQUENCES
Date: 2026-07-22 05:42:53
Message-ID: CAJpy0uB2+50A6yJHfzetQebzyhmuVCN_tUddURthPH=skNWqrw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 22, 2026 at 10:19 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Jul 22, 2026 at 9:09 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > On Wed, Jul 22, 2026 at 8:58 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > >
> > > When this idea was discussed earlier, I had asked whether we could
> > > move the version check from copy_sequences() to the apply worker
> > > (ProcessSequencesForSync) before it starts sequnece sync worker. The
> > > intention was to avoid repeatedly starting the sequence-sync worker
> > > only for it to exit in copy_sequences(). The apply worker itself could
> > > report an error similar to how the backend reports it during REFRESH.
> > > Thoughts?
> >
> > Apply-worker can report a WARNING instead of ERROR. It's no use if the
> > apply worker keeps exiting and restarting instead of the seqsync
> > worker.
> >
>
> I feel the WARNINGs can go unnoticed. Anyway, we do restart sync/apply
> workers on ERROR or parameter change, so it seems okay to give ERROR
> from sequence syncworker itself.
>

Okay, works for me.

thanks
Shveta

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-07-22 05:50:12 Tracking per-RelOptInfo uniqueness during planning
Previous Message shveta malik 2026-07-22 04:59:49 Re: Support EXCEPT for ALL SEQUENCES publications