| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Improve pg_sync_replication_slots() to wait for primary to advance |
| Date: | 2025-10-15 08:38:24 |
| Message-ID: | CAJpy0uB+gY0_teigyyTHyNA0OVXFSbtLkLG_W7_VSFYO7QZ35g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 15, 2025 at 9:57 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
>
> Updated the patch with a tap test.
> Attaching patch v17 which has a tap test to test the feature added.
>
Thanks for the patch. I noticed that in the case of API, we are
passing 'some_slot_updated' as always false to
wait_for_slot_activity(). Shouldn't we pass it as actual value just
like slotsync worker does? There may be a case that in a given cycle,
one of the temp slots is persisted or one of the persisted slots is
updated, in such a case we should not double the naptime. The naptime
doubling logic is only when there is no activity happening on primary.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2025-10-15 08:40:03 | Re: Implement waiting for wal lsn replay: reloaded |
| Previous Message | Chao Li | 2025-10-15 08:28:28 | Re: Logical Replication of sequences |