| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Regardign RecentFlushPtr in WalSndWaitForWal() |
| Date: | 2024-03-11 10:46:50 |
| Message-ID: | CAJpy0uAx_dw6m1-yCtumgZ7jD3t4EP3V0QnDwhg4G3h6yAi8hA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 2, 2024 at 4:44 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Right, I think the quoted code has check "if (!RecoveryInProgress())".
>
> >
> But apart from that, your
> > observation seems accurate, yes.
> >
>
> I also find the observation correct and the code has been like that
> since commit 5a991ef8 [1]. So, let's wait to see if Robert or Andres
> remembers the reason, otherwise, we should probably nuke this code.
Please find the patch attached for the same.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-redundant-RecentFlushPtr-fetch-in-WalSndWa.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2024-03-11 10:48:35 | Re: Add comment to specify timeout unit in ConditionVariableTimedSleep() |
| Previous Message | Alexander Korotkov | 2024-03-11 10:44:53 | Re: [HACKERS] make async slave to wait for lsn to be replayed |