Re: doc: Improve wal_level and effective_wal_level GUC around logical replication

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: doc: Improve wal_level and effective_wal_level GUC around logical replication
Date: 2026-04-08 03:59:59
Message-ID: CAJpy0uAv36NnfLH=t+XUbwF+o1DYvF4P+cFbwh9R2DvmRW7nQg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Few comments:

1)
+ Running read-only queries on a standby server.

Looks incomplete and disconnected from previous sentence.

2)
+ level used by the system. Namely, whether replica has been promoted to
+ logical (minimal never promotes).

We shall replace replica, logical, minimal with below
<literal>replica</literal>
<literal>logical</literal>
<literal>minimal</literal>

Also shall we add 'wal_level'? Otherwise, 'replica' on its own could
be understood as a replica server:

Namely, whether wal_level replica has been promoted to ....

3)
+ The <xref linkend="guc-effective-wal-level"/> parameter
reports the actual
+ level used by the system. Namely, whether replica has been promoted to
+ logical (minimal never promotes).
+ This parameter can only be set at server start.

"This" here is misleading. Does this refer to wal_level or effective_wal_level?

4)
Below that is <literal>minimal</literal>,

Shall we change "that" to <literal>replica</literal> to avoid any confusion?

thanks
Shveta

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-04-08 04:06:07 Re: pg_test_timing: fix unit typo and widen diff type
Previous Message Chao Li 2026-04-08 03:50:16 Re: PoC: Add condition variable support to WaitEventSetWait()