| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |
| Date: | 2026-04-29 03:27:51 |
| Message-ID: | CAJpy0uApaWwXUrjP+FqcYmVG7bnS-u2WWvchwvr8u6d47RxT0w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 29, 2026 at 7:12 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Wed, Apr 29, 2026 at 12:17 AM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >
> >
> >
> > Please find the attached v4 patch. Thank yoU!
> >
>
> One small comment. The includes need to be in alphabetical order.
> injection_point.h should come after fmgroids.h
>
> #include "utils/fmgroids.h"
> #include "utils/lsyscache.h"
> #include "utils/rel.h"
> +#include "utils/injection_point.h"
> #include "utils/syscache.h"
>
+1
Also there is a trailing whitespace issue while applying the patch.
Other than these, the patch looks good.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2026-04-29 03:39:07 | Re: Support logical replication of DDLs, take2 |
| Previous Message | Nathan Bossart | 2026-04-29 02:29:12 | Re: New vacuum config to avoid anti wraparound vacuums |