| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: Review items for EXCEPT TABLE publication |
| Date: | 2026-09-10 09:36:16 |
| Message-ID: | CAJpy0uAD1Ds1QDjXnZR_xxTy5f7Od0o5mMmEL9MLwAvT67=o0A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
patch 002:
Commit msg says:
----------
The command then re-fetches the publication tuple after acquiring the
lock, but does not revalidate the publication relations. This can leave
pg_publication_rel containing a mixture of inclusion and exclusion rows.
Re-run CheckAlterPublication() after acquiring the lock so that the
validation uses the current publication state.
---------
The commit message and the fix are not in sync and thus little
confusing. Commit msg talks about re-validation while patch has
shifted the validation to a later point. The code change looks good
though.
patch003: LGTM
patch004: LGTM
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-09-10 09:37:52 | Re: Review items for EXCEPT TABLE publication |
| Previous Message | Richard Guo | 2026-09-10 09:33:37 | Re: remove_useless_joins vs. bug #19560 |