| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-10-19 09:05:28 |
| Message-ID: | CAJpy0uA9Z=1pc=Gsuqx12eB7pZa7g56Y5PduLpzO3cR8exdX5A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Few trivial things for v82-002:
1)
+errdetail("Prepared transactions of the subscription may hold a lock
on its conflict log table."),
I think usgae of 'its' is not very clear here. Suggestion:
errdetail("Prepared transactions of the subscription may hold a lock
on the conflict log table.")
or
errdetail("Prepared transactions of the subscription may hold a lock
on the subscription's conflict log table.")
Please change at both places if you agree.
2)
+ (void) set_config_option("datestyle", "ISO",
+ PGC_USERSET, PGC_S_SESSION,
+ GUC_ACTION_SAVE, true, 0, false);
We can move this to 003 so that complete fix is in same patch. Commit
message of 002 too does not mention this change either.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2026-10-19 09:22:48 | Re: postgres_fdw: transaction mode inheritance corner cases |
| Previous Message | Marko Grujic | 2026-10-19 09:05:22 | Re: query_int wrongly parses zero-padded input |