From: | Andrew Bille <andrewbille(at)gmail(dot)com> |
---|---|
To: | wenjing <wenjing(at)gmail(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tony Zhu <Tony(dot)zhu(at)ww-it(dot)cn>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [Proposal] Global temporary tables |
Date: | 2022-01-10 09:17:23 |
Message-ID: | CAJnzarwfCozjDm74Ps-tQO_g-2CZ-ObuDP5k8eCDRsaFaNdg2w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi!
I could not detect crashes with your last patch, so I think the patch is
ready for a review.
Please, also consider fixing error messages, as existing ones don't follow
message writing guidelines.
https://www.postgresql.org/docs/14/error-style-guide.html
Regards, Andrew
On Thu, Dec 23, 2021 at 7:36 PM wenjing <wjzeng2012(at)gmail(dot)com> wrote:
>
>
> Andrew Bille <andrewbille(at)gmail(dot)com> 于2021年12月21日周二 14:00写道:
>
>> Hi!
>> Thanks for new patches.
>> Yet another crash reproduced on master with v63 patches:
>>
>> CREATE TABLESPACE ts LOCATION '/tmp/ts';
>> CREATE GLOBAL TEMP TABLE tbl (num1 bigint);
>> INSERT INTO tbl (num1) values (1);
>> CREATE INDEX tbl_idx ON tbl (num1);
>> REINDEX (TABLESPACE ts) TABLE tbl;
>>
> This is a feature made in PG14 that supports reindex change tablespaces.
> Thank you for pointing that out and I fixed it in v64.
> Waiting for your feedback.
>
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-01-10 09:20:14 | Re: Why is src/test/modules/committs/t/002_standby.pl flaky? |
Previous Message | Andrey Borodin | 2022-01-10 09:10:47 | Re: reporting TID/table with corruption error |