Use outerPlanState() consistently in executor code

From: Qingqing Zhou <zhouqq(dot)postgres(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Use outerPlanState() consistently in executor code
Date: 2015-04-15 19:38:35
Message-ID: CAJjS0u3nEZvUUJN1q8b1cxd-OoJ09F=EU8WKLNq-_CFbKo9X6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In executor context, outerPlanState(node) is the same as
node->ss.ps.lefttree. We follow this in most places except a few. This
patch clean up the outliers and might save us a few instructions by
removing indirection.

Most of changes are trivial. Except I take out an outerPlan nullable
check in grouping iterator - as a it surely has a left child.

I noticed that we mixed use "node" for plan node and plan state. While
changing it can make code clear, but back patching could be terrible.

Regards,
Qingqing

Attachment Content-Type Size
nodestate.diff text/plain 12.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2015-04-15 19:42:24 Re: Turning off HOT/Cleanup sometimes
Previous Message Alvaro Herrera 2015-04-15 19:15:37 Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/