Re: fix oversight converting buf_id to Buffer

From: Qingqing Zhou <zhouqq(dot)postgres(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fix oversight converting buf_id to Buffer
Date: 2015-08-12 18:48:06
Message-ID: CAJjS0u3Yort607=+jmg456VBfqd6ZkRMw5rAPc0SBPcUnY_tvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

All look good to me,

Thank you,
Qingqing

On Wed, Aug 12, 2015 at 8:37 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2015-08-11 01:15:37 +0200, Andres Freund wrote:
>> I'm too tired right now to look at this, but it generally looked sane.
>
> Pushed your fix to master and 9.5, with two very minor changes:
> 1) I moved the BufferDescriptorGetBuffer() call in PinBuffer_Locked() to
> after the spinlock release. It's rather minor, but there seems
> little reason to do it before except the assert, which isn't compiled
> in production.
> 2) I removed the two asserts you added. They essentially asserted that
> i + 1 == i + 1.
>
> Thanks again for the catch and patch.
>
> Greetings,
>
> Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-08-12 18:52:42 Re: [COMMITTERS] Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)
Previous Message Alvaro Herrera 2015-08-12 18:20:36 Re: Test code is worth the space