Re: Division by zero in planner.c:grouping_planner()

From: Qingqing Zhou <zhouqq(dot)postgres(at)gmail(dot)com>
To: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Division by zero in planner.c:grouping_planner()
Date: 2015-07-29 19:20:46
Message-ID: CAJjS0u0eJpGgk92SRYAakEC8VGqJqxKCpxt8fVbEC2eyXVjKkg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 29, 2015 at 11:26 AM, Piotr Stefaniak
<postgres(at)piotr-stefaniak(dot)me> wrote:
> + Assert(path_rows != 0);
> if (tuple_fraction >= 1.0)
> tuple_fraction /= path_rows;
> }
>

This does not sounds right: path_rows only used when tuple_fractions
>= 1.0. So the new Assert is an overkill.

Regards,
Qingqing

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2015-07-29 19:36:52 Re: more RLS oversights
Previous Message Qingqing Zhou 2015-07-29 19:14:38 Re: Planner debug views