Re: [PATCH] btree_gin, add support for uuid, bool, name, bpchar and anyrange types

From: Matheus de Oliveira <matioli(dot)matheus(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] btree_gin, add support for uuid, bool, name, bpchar and anyrange types
Date: 2018-03-30 20:51:28
Message-ID: CAJghg4+-ajdSKzcGuyv9Fc9kOCWhXw-RZT_AyqL0VnrpkX=U-w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi all.

On Wed, Mar 21, 2018 at 1:47 PM, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
wrote:

>
> Do you plan to post an updated version of the patch, of what is your
> response to the points raised last week?
>
>
Very sorry about the long delay. I've been in a long trip, no time to look
that carefully.

> I still haven't made my mind regarding usefulness of range opclasses, so
> I suggest to split the patch into two parts - 0001 for the opclasses
> we're confident are useful, and 0002 for those extras. The committer
> then may apply either 0001 or 0001+0002, depending on his judgment.
>
>
I liked the idea. So, follows the patches:
- 0001-btree_gin-uuid--base.v2.patch - all types but anyrange, and with the
adjustments on comments you proposed
- 0002-btree_gin-uuid--anyrange.v2.patch - adding the anyrange type (must
be applied after 0001)

Anything else missing?

Best regards,
--
Matheus de Oliveira

Attachment Content-Type Size
0001-btree_gin-uuid--base.v2.patch text/x-patch 26.5 KB
0002-btree_gin-uuid--anyrange.v2.patch text/x-patch 12.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2018-03-30 20:52:29 Re: BUG #15112: Unable to run pg_upgrade with earthdistance extension
Previous Message Tom Lane 2018-03-30 20:21:24 Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility