Re: [PATCH] btree_gin, add support for uuid, bool, name, bpchar and anyrange types

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Matheus de Oliveira <matioli(dot)matheus(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] btree_gin, add support for uuid, bool, name, bpchar and anyrange types
Date: 2018-04-05 11:16:57
Message-ID: 093e0ef3-9ac9-ba07-c969-6ed8abd46eba@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

somehow you missed some parts in 0001 patch, at least regression tests fail:

CREATE EXTENSION btree_gin;
+ ERROR: could not find function "gin_extract_value_uuid" in file
"/usr/local/pgsql/lib/btree_gin.so"

Matheus de Oliveira wrote:
> Hi all.
>
> On Wed, Mar 21, 2018 at 1:47 PM, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com
> <mailto:tomas(dot)vondra(at)2ndquadrant(dot)com>> wrote:
>
>
> Do you plan to post an updated version of the patch, of what is your
> response to the points raised last week?
>
>
> Very sorry about the long delay. I've been in a long trip, no time to look that
> carefully.
>
> I still haven't made my mind regarding usefulness of range opclasses, so
> I suggest to split the patch into two parts - 0001 for the opclasses
> we're confident are useful, and 0002 for those extras. The committer
> then may apply either 0001 or 0001+0002, depending on his judgment.
>
>
> I liked the idea. So, follows the patches:
> - 0001-btree_gin-uuid--base.v2.patch - all types but anyrange, and with the
> adjustments on comments you proposed
> - 0002-btree_gin-uuid--anyrange.v2.patch - adding the anyrange type (must be
> applied after 0001)
>
> Anything else missing?
>
> Best regards,
> --
> Matheus de Oliveira
>
>

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2018-04-05 11:38:07 Re: [HACKERS] MERGE SQL Statement for PG11
Previous Message Simon Riggs 2018-04-05 11:12:06 Re: Add support for printing/reading MergeAction nodes