| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Maxim Orlov <m(dot)orlov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Pengchengliu <pengchengliu(at)tju(dot)edu(dot)cn>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel scan with SubTransGetTopmostTransaction assert coredump |
| Date: | 2021-08-25 09:36:54 |
| Message-ID: | CAJcOf-ewwa_X0RQLcDGR3JPuwLcnORTm0Q0vUu8jFfGbRBG7PA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 25, 2021 at 1:37 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> I guess I was thinking more of rejiggering things so that we save the
> results of each RestoreSnapshot() call in a local variable, e.g.
> asnapshot and tsnapshot. And then I think we could just
> RestoreTransactionSnapshot() on whichever one we want, and then
> PushActiveSnapshot(asnapshot) either way. I think it would be worth
> trying to move the PushActiveSnapshot() call out of the if statement
> instead it in two places, written differently but doing the same
> thing.
>
I've attached an updated patch, hopefully more along the lines that
you were thinking of.
Regards,
Greg Nancarrow
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Fix-parallel-worker-failed-assertion-and-coredump.patch | application/octet-stream | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-08-25 09:37:25 | Re: Added schema level support for publication. |
| Previous Message | Daniel Gustafsson | 2021-08-25 08:56:31 | Re: Bug in error reporting for multi-line JSON |