| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "Tang, Haiying" <tanghy(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2021-02-12 04:14:02 |
| Message-ID: | CAJcOf-en-hL3U8mhZhpvy7xQqAUkYzB1G7Frr69wJqAkddtRSQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 12, 2021 at 2:33 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>
> For v17-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch :
>
> + /* Assume original queries have hasModifyingCTE set correctly */
> + if (parsetree->hasModifyingCTE)
> + hasModifyingCTE = true;
>
> Since hasModifyingCTE is false by the time the above is run, it can be simplified as:
> hasModifyingCTE = parsetree->hasModifyingCTE
>
Actually, we should just return parsetree->hasModifyingCTE at this
point, because if it's false, we shouldn't need to continue the search
(as we're assuming it has been set correctly for QSRC_ORIGINAL case).
> + if (!hasSubQuery)
> + return false;
> +
> + return true;
>
> The above can be simplified as:
> return hasSubQuery;
>
Yes, absolutely right, silly miss on that one!
Thanks.
This was only ever meant to be a temporary fix for this bug that
affects this patch.
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-02-12 04:23:40 | Re: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Kyotaro Horiguchi | 2021-02-12 04:09:22 | Re: parse mistake in ecpg connect string |