| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2021-07-30 06:32:51 |
| Message-ID: | CAJcOf-eGCg8s+tT_Mo5xKksAhA==1QAH_Sj7SqBotHQhwapdEw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 30, 2021 at 2:02 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Please find attached the latest patch set v100*
>
> v99-0002 --> v100-0001
>
A few minor comments:
(1) doc/src/sgml/protocol.sgml
In the following description, is the word "large" really needed? Also
"the message ... for a ... message" sounds a bit odd, as does
"two-phase prepare".
What about the following:
BEFORE:
+ Identifies the message as a two-phase prepare for a
large in-progress transaction message.
AFTER:
+ Identifies the message as a prepare for an
in-progress two-phase transaction.
(2) src/backend/replication/logical/worker.c
Similar format comment, but one uses a full-stop and the other
doesn't, looks a bit odd, since the lines are near each other.
* 1. Replay all the spooled operations - Similar code as for
* 2. Mark the transaction as prepared. - Similar code as for
(3) src/test/subscription/t/023_twophase_stream.pl
Shouldn't the following comment mention, for example, "with streaming"
or something to that effect?
# logical replication of 2PC test
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-07-30 06:42:18 | Use generation context to speed up tuplesorts |
| Previous Message | Fujii Masao | 2021-07-30 06:26:51 | Re: Fix around conn_duration in pgbench |