| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small documentation improvement for ALTER SUBSCRIPTION |
| Date: | 2021-08-12 04:19:36 |
| Message-ID: | CAJcOf-duvwkJ7iuXWTA6dPOesceWzPJP2+-9EjcC_x4W=+Ze8w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 12, 2021 at 12:53 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Yeah, I prefer my original patch over this idea. On the other hand, I
> can see the point of review comment on it that Amit pointed out[1].
>
> Regards,
>
> [1] https://www.postgresql.org/message-id/CAA4eK1KaWwUSkDEKPseVY-z00kQJfpfVFdJCXPv9_CrwVZPMhg%40mail.gmail.com
>
Personally, I don't really think the wording that results from the
original patch is great, because it doesn't give the impression of
multiple options.
I prefer something like:
Additionally, refresh options may be specified, as described under
<literal>REFRESH PUBLICATION</literal> supported
<replaceable>refresh_option</replaceable> values, except in the case
of <literal>DROP PUBLICATION</literal>.
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-12 04:22:18 | Re: Next Steps with Hash Indexes |
| Previous Message | Amit Kapila | 2021-08-12 04:19:18 | Re: Next Steps with Hash Indexes |