| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2021-01-18 03:12:07 |
| Message-ID: | CAJcOf-dguggX1oVMDPfMv5wqogrHZSbixQtu-ZCM7d3TyFG69w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 8, 2021 at 8:25 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> For one of the test you can validate that the same transaction has
> been used by all the parallel workers, you could use something like
> below to validate:
> SELECT COUNT(*) FROM (SELECT DISTINCT cmin,xmin FROM para_insert_p1) as dt;
>
> Few includes are not required:
> #include "executor/nodeGather.h"
>
> This include is not required in nodeModifyTable.c
>
>
> The includes indexing.h, rewriteHandler.h & lmgr.h is not required in clauses.c
>
> exeption should be exception
>
> resonable should be reasonable
>
Thanks Vignesh,
I'll be sure to make those updates in the next version of the patches.
Regards,
Greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-01-18 03:17:06 | Re: Determine parallel-safety of partition relations for Inserts |
| Previous Message | Amit Kapila | 2021-01-18 03:04:38 | Re: Determine parallel-safety of partition relations for Inserts |