| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: logical replication empty transactions |
| Date: | 2021-07-23 00:26:16 |
| Message-ID: | CAJcOf-ddb44qJKfxXNM1TbhDcS3cA0VYNucLsnGi_bWCcuGiMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 22, 2021 at 11:37 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
I have some minor comments on the v9 patch:
(1) Several whitespace warnings on patch application
(2) Suggested patch comment change:
BEFORE:
The current logical replication behaviour is to send every transaction to
subscriber even though the transaction is empty (because it does not
AFTER:
The current logical replication behaviour is to send every transaction to
subscriber even though the transaction might be empty (because it does not
(3) Comment needed for added struct defn:
typedef struct PGOutputTxnData
(4) Improve comment.
Can you add a comma (or add words) in the below sentence, so we know
how to read it?
+ /*
+ * Delegate to assign the begin sent flag as false same as for the
+ * BEGIN message.
+ */
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tanghy.fnst@fujitsu.com | 2021-07-23 00:56:29 | RE: Added schema level support for publication. |
| Previous Message | Peter Smith | 2021-07-23 00:13:00 | Re: logical replication empty transactions |