Re: On login trigger: take three

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: Re: On login trigger: take three
Date: 2021-11-16 05:38:33
Message-ID: CAJcOf-cq9=f_hz9DXKFJBVNGK1C68XsxhKXYZ7PkzGgb=jDh7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 11, 2021 at 8:56 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> + This flag is used to avoid extra lookups on the pg_event_trigger table during each backend startup.
> This should be <structname>pg_event_trigger</structname>. Sorry, missed that
> one at that last read-through.
>
Fixed.

> > - dathaslogintriggers -> dathasloginevttriggers flag rename (too
> > long?)
>
> I'm not crazy about this name, "evt" is commonly the abbreviation of "event
> trigger" (used in evtcache.c etc) so "dathasloginevt" would IMO be better.
> That being said, that's still not a very readable name, maybe someone else has
> an even better suggestion?
>
Changed to "dathasloginevt", as suggested.

I've attached an updated patch with these changes.
I also noticed one of the Windows-based cfbots was failing with an
"SSPI authentication failed for user" error, so I updated the test
code for that.

Regards,
Greg Nancarrow
Fujitsu Australia

Attachment Content-Type Size
v22-0001-Add-a-new-login-event-and-login-event-trigger-support.patch application/octet-stream 23.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amul Sul 2021-11-16 05:47:27 Unnecessary global variable declared in xlog.c
Previous Message Shinya Kato 2021-11-16 05:26:37 Re: [Proposal] Add foreign-server health checks infrastructure